Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrations #34

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Add migrations #34

merged 11 commits into from
Jun 4, 2024

Conversation

p3rcypj
Copy link
Contributor

@p3rcypj p3rcypj commented May 6, 2024

📌 References

📝 Implementation

  • Review if duplicate bug to import id fixed without filtering
  • Remove the code that was creating the bug
  • Validate duplication logic in entity
  • Create test to verify the duplication node logic validation
  • Verify new functionality about action of type landing
  • Implement Migrations (almost ready to be exported as a library)

📹 Screenshots/Screen capture

image

🔥 Testing

Tested vs https://dev.eyeseetea.com/play/

@p3rcypj p3rcypj requested review from xurxodev and adrianq May 6, 2024 09:04
Copy link
Contributor

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @p3rcypj

Congratulations good work!

I've tested and it works for me.

I've only minor things to review in the potential folder to be extracted in a lib: d2-migrations.

If we are going to use Clean Architecture within of this folder I would rather some changes:

  • Create our typical structure
    • data
      • DataStoreStorage.ts
    • domain
      • repositories
        • MigrationStorage
      • entities
        • Migration.ts
      • use-cases
        • MigrationsRunner -> RunMigrations (and review what methods are necessary as public)
    • presentation
      • Migrations.tsx
      • useMigrations.ts
    • types
      • d2-api.ts
      • utils.ts
    • index.ts
    • utils.ts

@p3rcypj p3rcypj requested a review from xurxodev June 2, 2024 20:34
Copy link
Contributor

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @p3rcypj

@adrianq adrianq merged commit 2b71d7b into development Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants