-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migrations #34
Add migrations #34
Conversation
…le d2-api into Storage agnostic implementation, useHook directly inside component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @p3rcypj
Congratulations good work!
I've tested and it works for me.
I've only minor things to review in the potential folder to be extracted in a lib: d2-migrations.
If we are going to use Clean Architecture within of this folder I would rather some changes:
- Create our typical structure
- data
- DataStoreStorage.ts
- domain
- repositories
- MigrationStorage
- entities
- Migration.ts
- use-cases
- MigrationsRunner -> RunMigrations (and review what methods are necessary as public)
- repositories
- presentation
- Migrations.tsx
- useMigrations.ts
- types
- d2-api.ts
- utils.ts
- index.ts
- utils.ts
- data
…into feature/migrations
…into feature/migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @p3rcypj
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Testing
Tested vs
https://dev.eyeseetea.com/play/