tui: don't log.Fatal on appView.Run error #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user closes their terminal (as opposed to ctrl-c), the terminal might close the tty without waiting for process-compose to exit. This causes pcv.appView.Run to return an error, which triggers a log.Fatal: ERR Failed to start TUI error="read /dev/tty: input/output error" This leads to a race where log.Fatal might call os.Exit before the project's processes can be stopped, leaving them orphaned. Change log.Fatal to log.Error and explicitly shutdown the project to make sure processes aren't left behind.
|
|
Hey @F1bonacc1, this is something we ran into when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user closes their terminal (as opposed to ctrl-c), the terminal might close the tty without waiting for process-compose to exit. This causes
pcv.appView.Runto return an error, which triggers alog.Fatal:This leads to a race where
log.Fatalmight callos.Exitbefore the project's processes can be stopped, leaving them orphaned.Change
log.Fataltolog.Errorand explicitly shutdown the project to make sure processes aren't left behind.