Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #63 Update to make "latest" default on deployment template #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TJbredow
Copy link

@TJbredow TJbredow commented Jul 9, 2022

Problem: Image pull would error on machines running CRI-O due to the colon being added after the image name regardless of whether the version variable was defined in the values.yaml.

Solution: Added logic to only have the colon when version is defined.

Testing: Ran helm chart on cluster running CRI-O and another running Containerd

Running CRI-O, the colon appended before the version being added would fail to pull the image. Added logic to account for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant