Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander Transport Search Hotkey Upgrade #6534

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

clyfordv
Copy link
Contributor

Modifies the existing select/zoom to commander keyactions to use a new SelectCommander function, which searches possible transports and selects/zooms to them if it doesn't find a commander on the ground.

For cases of multiple commanders:

  • Prioritizes the nearest commander not in a transport (like the stock implementation)
  • If there's no grounded commanders, it finds one in a transport at random. There's unfortunately no method for the UI to search by both attached units and distance

In case of no commander it clears the selection

@Garanas Garanas added the feature: hotkeys related to miscellaneous hotkeys label Nov 19, 2024
@Garanas
Copy link
Member

Garanas commented Nov 19, 2024

@clyfordv this is branched from deploy/fafdevelop instead of develop. Next time, please branch from develop

@clyfordv clyfordv merged commit 012e944 into FAForever:develop Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: hotkeys related to miscellaneous hotkeys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants