Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetArmyBrain being called on observers in sim side of recall #6538

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Nov 16, 2024

Description of the proposed changes

Caused by #6396 with 81a2588.
Fixes the following error:

warning: Error running lua script: Invalid army -1. (Use a 1-based index)
         stack traceback:
         	[C]: in function `GetArmyBrain'
         	...\fa\lua\sim\recall.lua(114): in function `ArmyRecallRequestCooldown'
         	...\fa\lua\sim\recall.lua(474): in function <...\fa\lua\sim\recall.lua:465>

Testing done on the proposed changes

Switching to observer no longer generates the error.

Additional context

Checklist

- [ ] Changes are annotated, including comments where useful

  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added type: bug area: sim Area that is affected by the Simulation of the Game labels Nov 16, 2024
@lL1l1 lL1l1 requested a review from Garanas November 16, 2024 22:20
@lL1l1 lL1l1 marked this pull request as ready for review November 16, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant