Drop extraneous libc overrides #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing symbol visibility wasn't actually necessary. The true issue was that upstream jemalloc already overrides these symbols, so we didn't need these definitions in the first place. This reverts the following commits: * dea850b ("Adds missing posix_memalign alias") * 32a326c ("Override regular malloc symbols as well") * be75f8a ("Override the correct malloc_usable_size symbol") * 5ac9b45 ("Make sure to override __malloc_usable_size") * 9c3fd4b ("Use visibility("default") attribute for libc overrides")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing symbol visibility (see #1) wasn't actually necessary. The true issue was that upstream jemalloc already overrides these symbols, so we didn't need our own definitions in the first place.
As outlined upstream:
Tested against FEXConfig and Ender Lilies (with thunks).