Add test for compile errors in parsed source file. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More work is needed to fail for compile errors in transitively included headers.
| @@ -142,7 +142,7 @@ def test_class_member_data(): | |||
| class A {}; | |||
| class B { | |||
| int x_; | |||
| B b_; | |||
| A a_; | |||
There was a problem hiding this comment.
Was this just an error before?
ajbennieston
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Causes cppmodel to fail if the parsed file contains errors.
Closes [github issues]
#453
Possible future work
More work is needed to fail for compile errors in transitively included headers. (Causes test failures on macOS) #458