Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for SQLJSPackageDB #33

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add tests for SQLJSPackageDB #33

merged 4 commits into from
Aug 22, 2024

Conversation

mint-thompson
Copy link
Collaborator

Test the save, find, stats, and clear class methods. No tests are added for the logging methods.

Minor styling changes in some other files, as applied by prettier.

Test the save, find, stats, and clear class methods. No tests are added
for the logging methods.

Minor styling changes in some other files, as applied by prettier.
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite nice. Elegant and clean. I only left a few comments -- nothing major. Thanks!

test/db/SQLJSPackageDB.test.ts Outdated Show resolved Hide resolved
test/db/SQLJSPackageDB.test.ts Show resolved Hide resolved
Check properties of the returned resource to make sure it matches one of
the expected results.

Remove unneeded comment from saveResourceInfo test.
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One more comment for your consideration.

test/db/SQLJSPackageDB.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mint. These tests looks great and cover all the needed functionality.

@cmoesel cmoesel merged commit efa241a into new-fpl Aug 22, 2024
14 checks passed
@cmoesel cmoesel deleted the new-fpl-db-tests branch August 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants