Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Old FPL Code #35

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Remove Old FPL Code #35

merged 1 commit into from
Aug 26, 2024

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Aug 23, 2024

Description: This PR removes all the old deprecated code from FHIR Package Loader 1.x (e.g., FHIRDefinitions, load, etc), as well as the corresponding tests. Since the new version was designed with a goal of re-use, a separate exported API is no longer needed; the library itself is the API. As a result, the README was also significantly updated. This PR also updates the CLI to use the new PackageLoader classes.

Testing Instructions: Ensure this branch builds and that all tests pass. Try the CLI. Review the README closely.

Related Issue: N/A

- Remove FHIRDefinitions
- Remove load function
- Remove old API (fpl function)
- Remove other unused errors, classes, and functions
- Update app.ts to use new classes
- Update README
@cmoesel cmoesel changed the base branch from main to new-fpl August 23, 2024 03:08
Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out on my system, and everything appears to build, test, and run correctly. I didn't see anything in the README that I wanted to change. Thank you!

@cmoesel
Copy link
Member Author

cmoesel commented Aug 26, 2024

We've been merging into new-fpl with just one approval since the new-fpl to master merge will be reviewed again. So I'm going to merge this. Thanks for the review, @mint-thompson!

@cmoesel cmoesel merged commit cdcc49b into new-fpl Aug 26, 2024
14 checks passed
@cmoesel cmoesel deleted the new-fpl-replaces-old branch August 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants