Update FSH parser+lexer and antlr4 dependency #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules for alias and paramRuleSet are changed. Use new child rules to get entity details. Resolve with null instead of rejecting when providing definition. The result is the same, but it avoids filling up the extension host logs.
jafeltra
reviewed
Sep 18, 2024
cmoesel
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New versions of the antlr4 package and type definitions are used. Update the FSH parser and lexer to the newest SUSHI grammar that was generated with that version of antlr4.
Rules for alias and paramRuleSet are changed. Use new child rules to get entity details.
Resolve with null instead of rejecting when providing definition. The result is the same, but it avoids filling up the extension host logs.
Testing Instructions:
No test definitions are changed as a result of this update. Confirm that all tests pass on your system. Make use of the extension's features (particularly provide definition, as that relies on the parser) in a FSH project.
Related Issue:
Issue #79 is already closed, but the antlr4 dependency was not updated along with the other dependencies.