Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix selecting despawining entity #206

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Bugfix selecting despawining entity #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f55207
suppressed exception when selecting a despawining entity
graefjk Sep 28, 2023
77595ef
fixed null pointer exception
graefjk Sep 28, 2023
76665dc
changed "N/A" to "null"
graefjk Sep 29, 2023
a415083
added comment explaining suppressed exception
graefjk Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../main/java/de/unistuttgart/informatik/fius/icge/simulation/inspection/InspectionData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,11 @@ public Object getAttributeValue(final Object obj, final String name) {
if (p != null) {
try {
return p.getValue(obj);
} catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
} catch (IllegalAccessException | IllegalArgumentException e) {
// TODO Auto-generated catch block
e.printStackTrace();
} catch (InvocationTargetException e) {
buehlefs marked this conversation as resolved.
Show resolved Hide resolved
// InvocationTargetException is suppressed to prevent crashes from methods that throw an exception when the value is null, e.g. getPosition();
}
}
return null;
Expand Down
6 changes: 5 additions & 1 deletion ...ava/de/unistuttgart/informatik/fius/icge/simulation/internal/StandardSimulationProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,11 @@ private EntityInspectorEntry[] getEntries(final Entity e) {
type = "readonly_string";
}
//TODO: this.inspectionManager.getAttributeType(e, name)
final String value = this.inspectionManager.getAttributeValue(e, name).toString();
final Object valueObject = this.inspectionManager.getAttributeValue(e, name);
String value = "null";
if (valueObject != null) {
value = valueObject.toString();
}
result.add(new EntityInspectorEntry(name, type, value, newValue -> {
this.inspectionManager.setAttributeValue(e, name, newValue);
this.playfield.drawEntities();
Expand Down
Loading