Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/login #104

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Fix/login #104

wants to merge 10 commits into from

Conversation

t4t5u0
Copy link
Contributor

@t4t5u0 t4t5u0 commented Aug 15, 2022

#101 がマージされたら,リベースして出し直します.

NavHostの実装上,一瞬ログイン画面が映ってしまう.正直挙動に納得いってないので,全部Jetpack Compose に置き換えたら作り直します

@t4t5u0 t4t5u0 added the Android label Aug 15, 2022
@t4t5u0 t4t5u0 self-assigned this Aug 15, 2022
@t4t5u0 t4t5u0 marked this pull request as ready for review August 17, 2022 06:42
cathiecode
cathiecode previously approved these changes Sep 2, 2022
Copy link
Contributor

@cathiecode cathiecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathiecode cathiecode dismissed their stale review September 2, 2022 01:09

SharedPreferenceまわりの議論を見てなかった

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🧐Wait a review
Development

Successfully merging this pull request may close these issues.

3 participants