Fixed Window dark mode issue for Windows 10 users! #449
Conversation
-Added `setWindowBorderColor()`, `hasVersion()`, and `redrawWindowHeader`.
| #if windows | ||
| flixel.FlxG.stage.window.borderless = true; | ||
| flixel.FlxG.stage.window.borderless = false; | ||
| #end |
There was a problem hiding this comment.
Is there a way to do this without toggling borderless? Can't you do UpdateWindow(window);
|
|
||
| UpdateWindow(window); | ||
| ') | ||
| public static function setWindowBorderColor(title:String, color:Array<Int>, setHeader:Bool = true, setBorder:Bool = false) {} |
There was a problem hiding this comment.
Tbh i would rather want setWindowBorderColor setWindowTitleColor
There was a problem hiding this comment.
DWM Attributes
DWMWA_BORDER_COLOR (34)
Use with DwmSetWindowAttribute. Specifies the color of the window border. The pvAttribute parameter points to a value of type COLORREF. The app is responsible for changing the border color according to state changes, such as a change in window activation.
- DWMWA_COLOR_NONE (
0xFFFFFFFE): Suppresses the drawing of the window border, allowing for a rounded window with no border. - DWMWA_COLOR_DEFAULT (
0xFFFFFFFF): Resets the window back to using the system's default behavior for the border color.
Supported: Starting with Windows 11 Build 22000.
DWMWA_CAPTION_COLOR (35)
Use with DwmSetWindowAttribute. Specifies the color of the caption. The pvAttribute parameter points to a value of type COLORREF.
- DWMWA_COLOR_DEFAULT (
0xFFFFFFFF): Resets the window back to using the system's default behavior for the caption color.
Supported: Starting with Windows 11 Build 22000.
DWMWA_TEXT_COLOR (36)
Use with DwmSetWindowAttribute. Specifies the color of the caption text. The pvAttribute parameter points to a value of type COLORREF.
- DWMWA_COLOR_DEFAULT (
0xFFFFFFFF): Resets the window back to using the system's default behavior for the caption text color.
Supported: Starting with Windows 11 Build 22000.
please do mention about the 0xFFFFFFFF/-1 being default color and that 0xFFFFFFFE/-2 is none color for the border, right now your code only does 0x00FFFFFF so theres no way for it to return to default color
| /** | ||
| * Switch the window's color to any color. This is exclusive to windows 11 users, unfortunately. | ||
| */ | ||
| public static function setWindowBorderColor(title:String, color:Array<Int>, setHeader:Bool = true, setBorder:Bool = false) { |
| @@ -156,6 +156,9 @@ class Main extends Sprite | |||
| FlxG.signals.postStateSwitch.add(onStateSwitchPost); | |||
|
|
|||
| FlxG.mouse.useSystemCursor = true; | |||
| #if DARK_MODE_WINDOW | |||
| if(funkin.backend.utils.NativeAPI.hasVersion("10")) funkin.backend.utils.NativeAPI.redrawWindowHeader(); | |||
There was a problem hiding this comment.
What about windows 11 or other platforms that have the text 10
| @:functionCode(' | ||
| int darkMode = enable ? 1 : 0; | ||
|
|
||
| HWND window = FindWindowA(NULL, title.c_str()); | ||
| // Look for child windows if top level aint found | ||
| if (window == NULL) window = FindWindowExA(GetActiveWindow(), NULL, NULL, title.c_str()); | ||
|
|
||
| if (window != NULL && S_OK != DwmSetWindowAttribute(window, 19, &darkMode, sizeof(darkMode))) { | ||
| DwmSetWindowAttribute(window, 20, &darkMode, sizeof(darkMode)); | ||
| } | ||
| ') | ||
| public static function setDarkMode(title:String, color:Array<Int>) {} |
There was a problem hiding this comment.
Please remove duplicate function
-Added a fix for Windows 10 users where they would have to unfocus and refocus the application to set the window to dark mode.
-Added
setWindowBorderColor, which can set the window header (and/or border) to any color.