Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcasting #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Broadcasting #4

wants to merge 2 commits into from

Conversation

spirosbax
Copy link

Add broadcasting functionality as per #3

FNj
FNj requested changes Mar 9, 2020
View reviewed changes
Copy link
Owner

@FNj FNj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just duplicated the line 20 in the runtests.jl file. There is no actual test of the new functionality. Please, add some actual tests of the new functionality. Also, please, add a description of the new functionality into README.md.

@FNj FNj linked an issue Mar 9, 2020 that may be closed by this pull request
Weird behavior with syntax error: all-underscore identifier used as rvalue #3
Open
@spirosbax
Copy link
Author

I must have committed the wrong file. I will fix it as soon as possible.

@FNj
Copy link
Owner

FNj commented Aug 5, 2020

Any update @spirosbax ?

@spirosbax
Copy link
Author

spirosbax commented Aug 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FNj FNj FNj requested changes

Assignees

@spirosbax spirosbax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behavior with syntax error: all-underscore identifier used as rvalue
2 participants
@spirosbax @FNj