Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.mdx #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Agility0493
Copy link

Add forgot root password and migration section

Add forgot root password and migration section
@admdly
Copy link
Contributor

admdly commented Mar 29, 2024

I’m unsure as to the desired purpose of these changes. If anything, they appear to be a downgrade and vastly increase complexity with little benefit.

If the intent is to simply provide migration instructions, then this could be done in a much simpler manner and without requiring manually setting a password for the database.

@Agility0493
Copy link
Author

@admdly The main goal: make it obvious the user needs to take note of their root password, and add instructions for migrating.

With the current docker compose example I did not know I needed to note the RANDOM_MYSQL_ROOT_PASSWORD when installing nor was I able to find it months later in my logs when needed.

I ended up spending a day learning how to recover my root password using the instructions I gave but would not have had the headache if I was required to enter my root password originally. I needed this to do a database dump for migrating to a new host.

Please share your improvements so we can avoid future users losing their root password and knowing how to migrate their fossbilling using docker. Thanks!

@admdly
Copy link
Contributor

admdly commented Mar 30, 2024

@admdly The main goal: make it obvious the user needs to take note of their root password, and add instructions for migrating.

Thanks for clarifying and we appreciate the effort to improve our documentation. However, there appears to be some misunderstanding.

With the current docker compose example I did not know I needed to note the RANDOM_MYSQL_ROOT_PASSWORD when installing nor was I able to find it months later in my logs when needed.

I ended up spending a day learning how to recover my root password using the instructions I gave but would not have had the headache if I was required to enter my root password originally. I needed this to do a database dump for migrating to a new host.

I'm sorry you had this issue, but you do not require the database root password to perform a dump of the fossbilling database - the standard user credentials can be used.

Please share your improvements so we can avoid future users losing their root password and knowing how to migrate their fossbilling using docker. Thanks!

The docs certainly can be improved around how to migrate the database between Docker containers and to/from Docker; improvements around that would be very much welcome.

However the root password steps are absolutely not required, nor do you need to take note of this at any point, as you can dump the database using the fossbilling database user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants