Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gruntfile: clean collection after unzipping #761

Merged
merged 1 commit into from
Jul 10, 2024
Merged

gruntfile: clean collection after unzipping #761

merged 1 commit into from
Jul 10, 2024

Conversation

kiike
Copy link
Contributor

@kiike kiike commented Jul 10, 2024 •
edited
Loading

This PR splits the clean:collection task into clean:collectionFile and clean:collection:

  • clean:collection removes the previously installed collection as the comment indicated.
  • clean:collectionFile downloads the file in the cache that was downloaded with wget:collection.

Then, when we run getcollection:

  1. the installed collection is cleaned (clean:collection)
  2. the collection is downloaded if not cached (wget:collection)
  3. the collection is unzipped (unzip:using-router)
  4. the cached file is cleaned (clean:collectionFile)

@kiike
gruntfile: clean collection after unzipping
f599b35 
Co-authored-by: Alberto Merino <[email protected]>
Co-authored-by: Enric Morales <[email protected]>
Co-authored-by: Roland Coeurjoly <[email protected]>

If we run the `clean:collection` task after unzipping, we allow
downloading the file manually into the cache directory so that the unzip
task doesn't try downloading it again.
@kiike
Copy link
Contributor Author

kiike commented Jul 10, 2024 •
edited
Loading

This time I tested it properly with Nix too 😄

@cavearr cavearr merged commit 327ad0d into FPGAwars:develop Jul 10, 2024
3 of 4 checks passed
@cavearr
Copy link
Member

cavearr commented Jul 10, 2024

Fix of #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiike @cavearr