Replace must_erase_during_extraction with erasable. #3519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
commented
Oct 3, 2024
| //notably in FStar.ModifiesGen, since this expands the class of computation types | ||
| //that can be promoted from ghost to tot. That in turn results in slightly different | ||
| //smt encodings, leading to breakages. So, sadly, I'm not including must_erase_for_extraction | ||
| //here. In any case, must_erase_for_extraction is transitionary and should be removed |
There was a problem hiding this comment.
FStar.ModifiesGen is still a big headache but it didn't cause any issues in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have two separate sets of functions which decide whether a type is erasable/noninformative, one which only looks at
erasableand another which also looks atmust_erase_for_extraction.This PR removes the
must_erase_for_extractionversion and treats themust_erase_for_extractionattribute as a (deprecated) alias forerasable. This is preparatory work for #3366, so that we only have a single place to change for erasability.Looking at the ML diff, the old code missed some opportunities to erase types to unit but there are no changes in executable code. Check world also gives a green.