Extraction: reduce krml output unless -d/--debug #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karamel extraction prints many warnings when definitions cannot be extracted, but most of these are benign, since they are just types, or ghost code, etc. This patch disables these warnings unless some debugging is enabled.
|
Just making a note: I should probably update the section here before merging, or make krml pass |
|
No objection for me, maybe this ties in to your other PR (or discussion) about having something like |
|
Yes absolutely, I need to do that too : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @msprotz , wondering if you think this makes sense. I usually see a lot of output from extraction runs that are all benign. This would prevent them unless you pass
-d(#3527) or some other debug toggle.