Makefile: fix clean rule #3535
Merged
Makefile: fix clean rule #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clean-buildfiles subrule could only work after a build, and failed on a fresh repo. Given we only needed it to decrease the size of docker images after a build (which we soon won't do) and didn't have automatic pruning (we do now), this is not that useful. Just remove it and clean as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clean-buildfiles subrule could only work after a build, and failed on a fresh repo. Given we only needed it to decrease the size of docker images after a build (which we soon won't do) and didn't have automatic pruning (we do now), this is not that useful.
Just remove it and clean as before.
@tahina-pro I broke this and didn't notice, sorry. I think this doesn't really matter now since we autoclean the docker images (and that will all be gone with new CI soon).