Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted open: fix shadowing #3559

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Conversation

W95Psp
Copy link
Contributor

@W95Psp W95Psp commented Oct 12, 2024

Consider the following three modules:

module A
let a = "A.a"
let b = "A.b"
module B
let a = "B.a"
let b = "B.b"
include A {a}
module C
include B
let _ = b

Running fstar.exe C.fst was producing the error:

* Error 72 at /tmp/C.fst(5,8-5,9):
  - Identifier not found: [b]

This PR fixes that bug, I just forgot to filter names in push_include'.

I also had to add a filter method (and implem) for setlike, does that looks fine @mtzguido?

@mtzguido
Copy link
Member

Looks great Lucas, thanks! I added a test for the resolution, merging.

@W95Psp
Copy link
Contributor Author

W95Psp commented Oct 13, 2024

Ah, nice, thanks for adding the test!

@mtzguido mtzguido merged commit 44265c4 into FStarLang:master Oct 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants