Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POSIX-friendly syntax #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

concatime
Copy link

Hi, with this patch, I was able to compile Kremlin on a POSIX-friendly environment, which means:

  1. replace which by the POSIX command -v
  2. replace bash by POSIX sh

This helps a little bit more the build process by removing two dependencies.

@ghost
Copy link

ghost commented Feb 14, 2022

CLA assistant check
All CLA requirements met.

@msprotz
Copy link
Contributor

msprotz commented Feb 14, 2022

Thanks for your contribution! Could you tell us a little bit why this is important? I buy the changes related to which, but why get rid of bash? This complicates the behavior in that we can't really rely on bash-like wildcard expansion which in turn means that, if we want to "do things right", we have to use $(wildcard ) a lot in Makefiles. Also, if you're building kremlin, surely you must have bash installed somewhere, no?

@concatime
Copy link
Author

concatime commented Feb 14, 2022

On my local build, bash was not required, so I wrongly thought that I could simply swap it. That being said, from the CI (even tho I cannot access the log because it requries that I log-in with a Microsoft account, seriously?), it seems important. So yeah, you're right. I restored the SHELL to bash, and will install it on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants