make cases for lowstar_endianness consistent #252
Conversation
|
PascalCase = kremlin-generated file there are two such files: the snake_case one is in include/kremlin, the PascalCase one is in dist/generic/* The correct fix is probably to rename the snake_case one to something more meaningful, such as The auto-generated one contains function prototypes to be implemented by hand and allows making sure that the implementation of e.g. Hope this makes sense! |
There was a problem hiding this comment.
This is good, thanks. The files you modified are for a large part auto-generated or copied from another directory. Can you modify the source files in krmllib/c/{fstar_uint128*.h} rather? Then I can take care of refreshing dist after that and check that it's alright. Thanks!
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| #include "FStar_UInt128.h" | |||
| #include "FStar_UInt_8_16_32_64.h" | |||
| #include "lowstar_endianness.h" | |||
| @@ -2,4 +2,4 @@ USER_TARGET=libkrmllib.a | |||
| USER_CFLAGS= | |||
| USER_C_FILES=fstar_uint128.c | |||
| ALL_C_FILES= | |||
| ALL_H_FILES=FStar_UInt128.h FStar_UInt_8_16_32_64.h lowstar_endianness.h | |||
There was a problem hiding this comment.
same here should be the builtin one
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| #include "FStar_UInt128.h" | |||
| #include "FStar_UInt_8_16_32_64.h" | |||
| #include "lowstar_endianness.h" | |||
I don't mind which version to use but the warnings about this are annoying, let's decide on a casing.