Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix karamel.opam: add ctypes and ctypes-foreign #391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cmovcc
Copy link

@cmovcc cmovcc commented Oct 22, 2023

No description provided.

@msprotz
Copy link
Contributor

msprotz commented Oct 23, 2023

Build fail, please try to see with @pnmadelaine what's up

@msprotz
Copy link
Contributor

msprotz commented Nov 13, 2023

@pnmadelaine doesn't know what's going on -- @tahina-pro do you have a clue?

@msprotz
Copy link
Contributor

msprotz commented Dec 19, 2023

Maybe @mtzguido knows?

@mtzguido
Copy link
Member

I think it's jump OPAM defaulting to no when installing dependencies. Trying..

@mtzguido
Copy link
Member

Sigh I think this is a discrepancy between the standalone build and the hierarchic one. The standalone build already does set OPAMYES=1, so the previous CI job from the original commit should have worked. The ones for my pushes just now are hierarchical (since there's an F* image on the machine), and seem to work even before my change (the merge is green).

I think the proper thing to do is removing the two flavors and just have one, but unsure on what that actually looks like if we want it to be fast. Also this should at least work around the problem if it shows up again.

diff --git a/.docker/standalone.Dockerfile b/.docker/standalone.Dockerfile
index d92931a0..b7c20531 100644
--- a/.docker/standalone.Dockerfile
+++ b/.docker/standalone.Dockerfile
@@ -12,6 +12,8 @@ RUN apt-get update && \
       git \
       gawk \
       coreutils \
+      libffi-dev \
+      pkg-config \
       sudo \
       opam \
       python3 \

@msprotz
Copy link
Contributor

msprotz commented Dec 19, 2023

@cmovcc can I let you add Guido's patch to this PR? thanks!

@msprotz
Copy link
Contributor

msprotz commented May 24, 2024

What's the status of this? Should it be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants