Port to 1.21 #288
Merged
Port to 1.21 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using vanilla's beacon beam render type, no need for a custom one
desht
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything looks to be working correctly other than the waypoint in-world beam. I can't seem to figure out what is going wrong with the render but I'm seeing this
(https://c.mikey.pro/scr/jPuFnsyV.png)
It's hard to make out but it is there... This happens on both forge and fabric so I don't believe it's the placement of the events
Instead of
(https://c.mikey.pro/scr/OeIZw9kC.png)