Moved the join clause from the SelectStatement to the StatementContainer #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2016 10:01
…ner because it can be used for cross table filtering on any query.
…is to allow the creation of other unconventional statement types like stored procedures. I alos moved the join clause from the select to the abstract StatementContainer. Some of these maybe backward compatable.
|
@kwhat Let me know when I can merge the whole PR. 😉 |
|
@FaaPz So I am not entirely sure how many changes I need to make ;) A lot of these changes are just suggestions based on some of the interface changes I needed to make for MsSql support. I would like to keep the commits small and iterate, so let me find a good cut off point and i'll let you know. I need to focus on stabilizing the code I am using your library with for the next couple of weeks, but I'll probably start making new PR's after that. On a related note, is there a v2 road map and/or timeline? |
|
Yes, of course! I finally made a small road map, but it's far from complete... #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… because it can be used for cross table filtering on any query.