Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Touch Bar support #387

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Touch Bar support #387

wants to merge 1 commit into from
+34 −0

Conversation

haykam821
Copy link

No description provided.

liach
liach approved these changes May 15, 2021
View reviewed changes
Copy link
Contributor

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this doesn't break non-mac systems

@liach liach requested review from 2xsaiko and a team May 15, 2021 02:46
@modmuss50 modmuss50 self-requested a review May 15, 2021 11:51
@modmuss50
Copy link
Member

I like the idea, just need to add some buttons to it.

@haykam821
Copy link
Author

If there is a refactor to the existing menu bar system, then buttons could be added to the Touch Bar without requiring too much work. However, the default set of Touch Bar buttons will get too cluttered, since I believe the default is all registered buttons.

I also need to look into Touch Bar icons that can use SF Symbols because the available set is just not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liach liach liach approved these changes

@2xsaiko 2xsaiko Awaiting requested review from 2xsaiko

@modmuss50 modmuss50 Awaiting requested review from modmuss50

Assignees
No one assigned
Labels
enhancement interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haykam821 @modmuss50 @liach