-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Partially Deobfuscated Classes
panel
#482
Draft
NebelNidas
wants to merge
4
commits into
FabricMC:master
Choose a base branch
from
NebelNidas:partially-deobfuscated-classes-panel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Partially Deobfuscated Classes
panel
#482
NebelNidas
wants to merge
4
commits into
FabricMC:master
from
NebelNidas:partially-deobfuscated-classes-panel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works fine with my testing. The only issues left are ones that have to be fixed by other PRs:
|
9 tasks
This was referenced Feb 15, 2023
This PR has some serious performance problems when importing larger JARs, and to be fair, the UI isn't great either with how clamped up everything gets, I think this needs a larger overhaul later down the line when my new IR stuff is finished and Matcher support gets added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the discussion on Discord from May, I've split up the deobfuscation panel into two: A
Partially Deobfuscated Classes
panel and aFully Deobfuscated Classes
one.While being at it, here are some related changes I made:
moveClassTree
function, fixed a bug introduced over two years ago via QOL fixes - Volume 2 #239 which rendered the lastelse
condition unreachableClassPanel
abstract class which the three other class panels inherit from. Also moved them into a new subpackage, although I wasn't quite sure how to name it, so please tell me if you have a better nameGuiController.java
, it now uses the methods fromGui.java
DeobfPanelPopupMenu
toClassPanelContextMenu
, as it can be used on all three panels nowIt may not be the cleanest of implementations, but hey, it works 😄