Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just a tiny bug in Mixin's local calculations that causes a hard crash if triggered.
The second commit is more interesting:
I forced Mixin's LVT generation on every method in every mixin target class on AOF7 and it failed on about 12 occasions with various exceptions, including 1 NPE that occurs naturally in the pack, and 4 attempts to live-load minecraft classes (!), albeit only on AppClassLoader so it didn't work anyway. The issues are largely related to attempts to look up
ClassInfo
s for array types, which do not exist.My overhaul includes:
isSubTypeOf
implementation largely taken from upstream ASM which has recently had many fixes toSimpleVerifier
isInterface
implementation that no longer throws on array typesisAssignableFrom
andmerge
implementations based on a bespokegetCommonSupertype
from MixinExtras' Expressions (the base implementation offloads most of this work to reflection which we cannot do)getClass
override to guard against accidental live-loadingAfter these changes there are no errors at all.