Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record signatures #2797

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

enbrain
Copy link
Contributor

@enbrain enbrain commented Oct 28, 2021

Fixes the genFakeSource errors e.g.

/__w/yarn/yarn/.gradle/temp/fakeSource/net/minecraft/class_6759.java:38: error: cannot find symbol
record class_6759(T type, BlockPos pos, int delay, TickPriority priority) {
                  ^
  symbol:   class T
  location: class class_6759

See https://github.com/FabricMC/yarn/runs/4033308142#step:5:196 for the list of errors.

@enbrain enbrain added bug Fixes or discusses a bug within the mappings snapshot A PR that targets a snapshot version of Minecraft labels Oct 28, 2021
@enbrain enbrain requested a review from a team October 28, 2021 12:31
@modmuss50 modmuss50 merged commit c1f4792 into FabricMC:21w43a Oct 28, 2021
@enbrain enbrain deleted the 21w43a-fix-record-signatures branch October 28, 2021 15:10
@enbrain
Copy link
Contributor Author

enbrain commented Oct 28, 2021

@modmuss50 publish job is failing https://github.com/FabricMC/yarn/runs/4036061706

@liach
Copy link
Contributor

liach commented Oct 28, 2021

well, gotta live with gradle wrapper validation failures 🤷

@modmuss50
Copy link
Member

Hum, I wonder where it’s getting rc-2 from? The wrapper might need updating. I’ll take a look.

@modmuss50
Copy link
Member

I have confirmed that our wrapper is the valid 7.2 release against:

https://downloads.gradle-dn.com/distributions/gradle-7.2-wrapper.jar.sha256

with a sha256 hash of 33ad4583fd7ee156f533778736fa1b4940bd83b433934d1cc4e9f608e99a6a89 I have no idea why its trying the 7.2-rc2.

This appears to be caused by: gradle/wrapper-validation-action#46 I have a feeling this might be one of those things that will fix its self magically, if not we can add a basic manual verification for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants