Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document inventories #3641

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

apple502j
Copy link
Contributor

Resolves #1705

@apple502j apple502j added snapshot A PR that targets a snapshot version of Minecraft javadoc A PR that adds or refactors javadoc. labels Aug 24, 2023
@Shnupbups Shnupbups merged commit 2af369c into FabricMC:23w33a Aug 24, 2023
6 checks passed
COMMENT {@return the size of the inventory}
COMMENT
COMMENT <p>The inventory should support the slot ID from {@code 0} to {@code size() - 1}.
COMMENT This should remain constant throughout the inventory's lifetime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessarily true for modded inventories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a big deal, Inventory is pretty bad in general anyway... :P)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javadoc A PR that adds or refactors javadoc. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory javadoc
4 participants