24w36a stuff #3977
Merged
24w36a stuff #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shnupbups
added
refactor
Co-Authored-By: apple502j <[email protected]>
quinn-semele
reviewed
Sep 4, 2024
| @@ -0,0 +1,4 @@ | |||
| CLASS net/minecraft/class_10200 net/minecraft/client/render/model/WrapperBakedModel | |||
There was a problem hiding this comment.
Is this a typo? Just mentioning since the field and constructor parameter are both named wrapped rather than Wrapper.
There was a problem hiding this comment.
Not a typo, the class is a wrapper for the wrapped model, but it could really be named either way /shrug
There was a problem hiding this comment.
Would the delegation pattern make sense here?
Closed
apple502j
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots more to do