Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent 3F and 4F suffix usage #3985

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Consistent 3F and 4F suffix usage #3985

merged 2 commits into from
Sep 18, 2024

Conversation

Octol1ttle
Copy link
Contributor

Fixes #3838

@apple502j apple502j added refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft labels Sep 12, 2024
@haykam821
Copy link
Contributor

Should the underscore variant be used instead? To me, 'vector 3f' feels more clear than 'vector3f'.

@Octol1ttle
Copy link
Contributor Author

Should the underscore variant be used instead? To me, 'vector 3f' feels more clear than 'vector3f'.

@apple502j @Shnupbups thoughts?

@Juuxel
Copy link
Member

Juuxel commented Sep 16, 2024

I'd say the underscore forms like VECTOR_3F are more readable.

@Shnupbups
Copy link
Contributor

I think I agree, underscores are more readable

@apple502j apple502j merged commit 66f4d63 into FabricMC:24w37a Sep 18, 2024
2 checks passed
@Octol1ttle Octol1ttle deleted the fix-3838 branch September 18, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haykam821 haykam821 haykam821 approved these changes

@Juuxel Juuxel Juuxel approved these changes

@apple502j apple502j Awaiting requested review from apple502j

Assignees
No one assigned
Labels
refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent underscores in fields named after the Vector3f class
5 participants
@Octol1ttle @haykam821 @Juuxel @Shnupbups @apple502j