Revise some Entity Brain Tasks names to better reflect their function #3992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brain tasks related to Walk and Look targets have inconsistent names that sometimes poorly reflect their function as well. For example,
LookAroundTask
andRandomLookAroundTask
are named as if they do the same thing, but one does it randomly. But actuallyLookAroundTask
reads fromLOOK_TARGET
memory, whileRandomLookAroundTask
writes to it.Therefore I suggest to unify task names under the following principle:
Look*
orLookAt*
Go
orGoTo*
WalkTowards*
LookAroundTask
that does neither of these should be renamed toUpdateLookControlTask
And the tasks that were previously named
GoTo*
, etc but don't update Look or Walk targets should be named in a different way, that better reflects their function too.Additionally:
TemptationCooldownTask
isn't used just for temptation, but to tick theRandomLookAroundTask
cooldown as well, so I suggest to rename it toTickCooldownTask
(and to rename it's fields and methods accordingly)LookTargetUtil
doesn't relate to just Look targets, but to several kinds of targets and has location utils, so I suggest to rename it to justTargetUtil