Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build changes to work around upstream packaging issue in poetry/isort, and to include pre-commit in venv packages. #5

Merged
merged 1 commit into from
May 1, 2023

Conversation

nyreed
Copy link
Contributor

@nyreed nyreed commented Apr 30, 2023

  1. Include pre-commit in requirements.txt so it is not required as a global dependency.
  2. include pre-commit autoupdate in setup.sh to work around issue in upstream packages below.
    package described here https://github.com/PyCQA/isort/issues/2083\#issuecomment-1408159596

Tested:
System: MacOS 12.6.5 (Monterey) - ARM64.
Python 3.11.2 (homebrew, ARM64)
pip 23.1.2

looks good.

Fix for bug #4
and bug #3

@FabrizioCafolla FabrizioCafolla merged commit 16a9398 into FabrizioCafolla:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Code refactoring
Projects
None yet
2 participants