-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove gmail.com.au from free email domains. #885
base: 2.0
Are you sure you want to change the base?
remove gmail.com.au from free email domains. #885
Conversation
Im not sure im a fan of this @bram-pkg since Faker only creates "valid structure" but never valid content. In fact the email address is valid. I think the problem is that a lookup is done on the domain. In fact i think most providers have the same problem in this case since . probably also does not exist |
We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think? |
Well it is valid but non existing. There is nothing wrong with the domain itself |
I think free emails should return actual free emails, not non existent ones. |
I must agree with @da-mask here. It should return known good email domains to register on for free. |
I'm not sure if you require further action from me? |
@pimjansen I don't know what's going on with BC Roave, do you know how to fix? |
We need to allow them with regex. Those in Core are acceptable since there is a non BC promise but those provider issues are bad though. |
Is there anything I can do to move this along? |
What is the reason for this PR?
freeEmail()
function for AU provider included the domaingmail.com.au
, which does not exist. It causes failing tests when validating emails withemail:rfc,dns
gmail.com.au
domain causes email validation to fail #886 )Author's checklist
Summary of changes
Removed the errant domain from the en_AU/Internet provider file
Review checklist
CHANGELOG.md