Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Person.php #901

Closed
wants to merge 1 commit into from
Closed

Conversation

mroussel-rhinos
Copy link

Hi,
French names are not combination of first name and last name.
In the list of $lastName you have already enough name to mix and match. They are different of last names.

fr_BE and fr_CH are correctly set so why fr_FR not ?

@bram-pkg
Copy link
Member

A full name most definitely includes a first name, right? If you only want last names, use the last name method.

@mroussel-rhinos
Copy link
Author

Yeah I agree with you but when you look at the code, names are set as full name (e.g.: {{firstNameMale}} {{lastName}}) so we have no issue to get only "{{lastName}}". That's the problem.

@pimjansen
Copy link

I still do not understand what you mean? If you want the lastname, pull it from the method?

@mroussel-rhinos
Copy link
Author

Hi Pimjansen and Bram

I've just realized that I'm using version 1.9, which is very old and does not have the lastname() method, only a name() method. This is why it was confusing.

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants