Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): show pending requests count in the sidebar #1223

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

AkashRajpurohit
Copy link

@AkashRajpurohit AkashRajpurohit commented Jan 5, 2025

Description

Add a pending requests count badge near the Requests tab in the sidebar, this helps to be able to view if there are any pending requests more easily rather than having to navigate specifically to the requests tab.

Screenshot (if UI-related)

image image

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • N.A

@gauthier-th
Copy link
Collaborator

You can already view the requests in the homepage?

@AkashRajpurohit
Copy link
Author

You can already view the requests in the homepage?

Yeah, so we do have recent requests section on the homepage, not sure how many recent requests we show exactly, but it shows list of all requests (approved, pending etc), the idea here was to show a badge for actionable requests (pending) in a quick glance.

Feel free to take a decision whether it makes sense to add this or not. ✌🏽

@gauthier-th
Copy link
Collaborator

I have nothing against the idea, but the feature should be only for request managers / admins.
From the quick glance I took, it looks like it'll be displayed for everyone.

@AkashRajpurohit
Copy link
Author

the feature should be only for request managers / admins

That makes sense, I'll add this.

@AkashRajpurohit AkashRajpurohit force-pushed the feat/show-pending-request-count branch from ff415bf to df12b61 Compare January 6, 2025 14:27
src/i18n/locale/en.json Outdated Show resolved Hide resolved
src/components/Layout/Sidebar/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants