-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display user score in discover view and filter it more flexable. #626
base: develop
Are you sure you want to change the base?
Conversation
…setting" This reverts commit 648ec69.
Does adding a settings by user if they want to see the score or not so it's not in default built-in |
That's OK, and where the setting section should this option be in? |
The most coherent for me I think is in the profile settings on the bottom left when clicking settings |
IMHO that makes discover posters very cluttered from an already cluttered view |
How about show the score on hover? |
Dont we already have the watchlist button occupying that space on hover? Imagine already requested ones. It will have media type badge, watchlist button, score badge. It will also kind of make mobile/touch ux a bit harder |
Yep, maybe we can do a little change to the UI. Maybe make the watchlist button more compact, like only show the icon. Another proposal is, how about make the watchlist button the same style as request button, and below it. From my understanding, watchlist and request are some kind of similar action, which stands for the interest. |
By the picture you make I can say that it's impossible to make it like that cause don't forget that they're is other language than English and movie translation or series can be more longer so it will break everything I think |
I think displaying rating is such a nice feature to have, would save a ton of clicks into details. However, I agree the current draft design looks awfully clustered, as @Fallenbagel noted. I even think that the favourites icon should be redesigned too to a solid design, because currently it does not fit aesthetically with the overseer's style. I can't really think of a nice way of doing this. We could replace the "movie" "series" label with something more simple, but that would be a big change, and I kind of got used to the label and like it. Or maybe some kind of hover animation in place of the label, but not sure, that would not work on mobile UI that great. Maybe lowering the font size a bit and max. length of the description? Having it on the side close to the right border? All of the options above dont feel right to me. Any other ideas? Edit: Actually, I what about moving the favourites icon somewhere else, details page? |
Description
The score cannot be seen in discover view, but the api has voteAverage data, just show it on the page. And the filter slide has default step=1, which is not very flexable, for I might be interested in movies that is larger than 7.5, or so. Just make the score filter more flexable by set the step to 0.1.
Screenshot (if UI-related)
[discover] before:
[discover] after:
[filter slide] after:
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed