feat: add postgres support + migrations #628

dr-carrot · 2024-01-19T22:08:17Z

Description

Screenshot (if UI-related)

To-Dos

Successful build yarn build
Translation keys yarn i18n:extract
Database migration (if required)

Issues Fixed or Closed

Fixes [Feature Request] Add support for external database connections #186

TODO:

An extra migration in the develop branch
Translation keys?
Docs
Test image - drcarrot/jellyseerr-postgres:latest
Move new docs from readme to the newer docs page
Switch date column types to remove timezone

Merge 'origin/develop' into main

Merge develop into main

Merge 'develop' into main

Merge develop into main

…ed ssl for postgres config Fallenbagel#186

Fallenbagel · 2024-01-20T20:17:30Z

Whats the difference between this and #421?

dr-carrot · 2024-01-20T22:53:17Z

Whats the difference between this and #421?

This PR contains all the changes in #421 plus changes from @ralgar that are also mentioned in that PR. Additionally, this PR contains the migration script required to get postgres running, documentation on how to configure postgres, and improved ssl configuration options

…nto v1.7.0/postgresql

captmicr0 · 2024-06-07T02:54:11Z

I've been using this branch for a couple months and semi-regularly get these two errors in my Postgres logs.
I did migrate from an existing sqlite database so I'm guessing this error is the result of that.

[5593] ERROR:  null value in column "mediaId" of relation "media_request" violates not-null constraint

[5593] DETAIL:  Failing row contains (541, 2, 2024-06-05 00:53:25.891558-04, 2024-06-05 00:53:25.933927-04, movie, null, 3, 3, f, null, null, null, null, null, f).

[5593] STATEMENT:  UPDATE "media_request" SET "mediaId" = $1, "updatedAt" = CURRENT_TIMESTAMP WHERE "id" = $2

[5593] ERROR:  syntax error at or near ")" at character 1610

[5593] STATEMENT:  SELECT "media"."id" AS "media_id", "media"."mediaType" AS "media_mediaType", "media"."tmdbId" AS "media_tmdbId", "media"."tvdbId" AS "media_tvdbId", "media"."imdbId" AS "media_imdbId", "media"."status" AS "media_status", "media"."status4k" AS "media_status4k", "media"."createdAt" AS "media_createdAt", "media"."updatedAt" AS "media_updatedAt", "media"."lastSeasonChange" AS "media_lastSeasonChange", "media"."mediaAddedAt" AS "media_mediaAddedAt", "media"."serviceId" AS "media_serviceId", "media"."serviceId4k" AS "media_serviceId4k", "media"."externalServiceId" AS "media_externalServiceId", "media"."externalServiceId4k" AS "media_externalServiceId4k", "media"."externalServiceSlug" AS "media_externalServiceSlug", "media"."externalServiceSlug4k" AS "media_externalServiceSlug4k", "media"."ratingKey" AS "media_ratingKey", "media"."ratingKey4k" AS "media_ratingKey4k", "media"."jellyfinMediaId" AS "media_jellyfinMediaId", "media"."jellyfinMediaId4k" AS "media_jellyfinMediaId4k", "watchlist"."id" AS "watchlist_id", "watchlist"."ratingKey" AS "watchlist_ratingKey", "watchlist"."mediaType" AS "watchlist_mediaType", "watchlist"."title" AS "watchlist_title", "watchlist"."tmdbId" AS "watchlist_tmdbId", "watchlist"."createdAt" AS "watchlist_createdAt", "watchlist"."updatedAt" AS "watchlist_updatedAt", "watchlist"."requestedById" AS "watchlist_requestedById", "watchlist"."mediaId" AS "watchlist_mediaId" FROM "media" "media" LEFT JOIN "watchlist" "watchlist" ON "watchlist"."mediaId"="media"."id" AND ("media"."id"= "watchlist"."mediaId" and "watchlist"."requestedById" = $1) WHERE "media"."tmdbId" in ()

This one seems to be because there is no value provided for the WHERE "media"."tmdbId" in () part of the statement.

github-actions · 2024-06-13T17:08:49Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

Lebowski89 · 2024-06-20T16:23:18Z

Keen to get this merged. Has been working great for me. Jumped over from overseerr just for this postgres support. Edit: Also, hope this isn't being held up because of any potential issues with migrating from sqlite to postgres. It should be the radarr/lidarr/sonarr/whisparr (etc) approach, where they officially support new instances with postgres and only offer some suggestions for migrating to postgres with no official support (see: https://wiki.servarr.com/radarr/postgres-setup).

Migrating an existing sqlite3 database is unsupported, and this script may not work without modifications which we cannot assist you with. We support only new installs using postgres.

croneter · 2024-06-21T05:59:02Z

Same. What's blocking a merge appart from an obvious rebase..?

package.json

Fallenbagel · 2024-05-10T20:45:51Z

CHANGELOG.md

Remove this file from this pr

Fallenbagel · 2024-05-10T20:50:37Z

server/utils/DbColumnHelper.ts

+import { Column } from 'typeorm';
+
+const pgTypeMapping: { [key: string]: ColumnType } = {
+  datetime: 'timestamp with time zone',


I believe it's best practice to always store time in db without the timezones

Fallenbagel · 2024-06-21T23:40:08Z

Same. What's blocking a merge appart from an obvious rebase..?

I added some review comments long ago. Forgot to submit it lol.

Also our focus for now is to get #815 in

github-actions · 2024-06-23T21:46:07Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

…nto v1.7.0/postgresql # Conflicts: # README.md # yarn.lock

nodadyoushutup · 2024-07-06T03:45:35Z

I know that this is not the current priority to get in, but do we have even a hand wave idea of potentially how long it may be? I can continue to use the preview container but I am eagerly awaiting this not being a preview feature :)

joaopedrocg27 · 2024-07-20T06:28:13Z

Is there a timeframe to merge this? Since running in kubernetes this is a deal breaker for now

RyuunosukeDS3 · 2024-08-06T18:14:22Z

Chiming in to say, I migrated from Overseerr to Jellyseerr for this. I'm also running in Kubernetes, and I'm trying to move everything I can to postgres.

juanlurie · 2024-08-12T09:21:39Z

I’d like to add this to my docker stack as well. Quite keen to have it working with Postgres

V1.7.0/postgresql dev merge

Fallenbagel and others added 16 commits January 30, 2023 01:31

Merge pull request Fallenbagel#312 from Fallenbagel/develop

7b82ced

Merge 'origin/develop' into main

chore(release): 1.4.0

20c821e

Merge pull request Fallenbagel#316 from Fallenbagel/develop

d3622f7

Merge develop into main

chore(release): 1.4.1

57e7d68

Merge pull request Fallenbagel#368 from Fallenbagel/develop

f3cc8cb

Merge 'develop' into main

chore(release): 1.5.0

24151d2

Merge branch 'develop'

4b54976

chore(release): 1.6.0

5712e19

Merge pull request Fallenbagel#477 from Fallenbagel/develop

e7c11da

Merge develop into main

chore(release): 1.7.0

325e2ed

feat: support for postgresql

b39a5a7

test(pgsql): disable root certificate verification

573b64f

test(ci): temporarily change CI for local repo

b6592bf

fix: don't use SQLite idiom when using PgSQL

abd80c1

feat(db): add flag to toggle TLS for Postgres

44aaca0

feat(postgres and migrations): added migrations for postgres & imporv…

4d85f29

…ed ssl for postgres config Fallenbagel#186

dr-carrot requested a review from Fallenbagel as a code owner January 19, 2024 22:08

dr-carrot changed the title ~~V1.7.0/postgresql~~ feat: add postgres support + migrations Jan 19, 2024

dr-carrot added 8 commits January 19, 2024 17:19

Merged changes from develop

e6cc2c5

fix: restored workflow actions

ed57911

fix: access order

14d3ec2

fix: added pushover sound migration tto initial migration

00c811d

fix: added option to log queries

0581d7b

fix: issue with session migration

e93ab06

chore: relocate pushover sound migration

b594dec

feat: added logging option to other datasources

8c7004c

dr-carrot added 2 commits January 20, 2024 17:50

chore: small tweaks for the datasource. Added docs for db setup

5018592

chore: cleanup logs

42ad4e0

dr-carrot added 4 commits May 8, 2024 17:53

fix: updated ts schema to align with change to migration

caaed7c

fix: switch timestamp to include timezone

94a9806

Merge branch 'develop' of https://github.com/Fallenbagel/jellyseerr i…

0280121

…nto v1.7.0/postgresql

fix: fixed indentation in psql docker-compose

2b0d497

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Jun 13, 2024

chore: merge from develop

e2992fe

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Jun 21, 2024

dr-carrot added 2 commits June 21, 2024 13:15

fix: changed version to 0.1.0 to remove ui notification

f8926fa

style: fixed prettier in docker-compose.pastgres.yaml

357b927

Fallenbagel requested changes Jun 21, 2024

View reviewed changes

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Jun 23, 2024

dr-carrot added 2 commits June 25, 2024 16:35

Merge branch 'develop' of https://github.com/Fallenbagel/jellyseerr i…

66e308b

…nto v1.7.0/postgresql # Conflicts: # README.md # yarn.lock

chore: restored CHANGELOG.md

bd7339a

gauthier-th mentioned this pull request Aug 12, 2024

Roadmap for Jellyseerr #926

Open

9 tasks

dr-carrot added 4 commits August 18, 2024 20:32

chore: revverted ts commit

3b12c98

chore: merge from dev

2add7af

fix: update pnpm lock with pg package

5ee2982

Merge pull request #3 from dr-carrot/v1.7.0/postgresql-dev-merge

4e63cee

V1.7.0/postgresql dev merge

dr-carrot requested a review from gauthier-th as a code owner August 19, 2024 03:26

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Aug 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add postgres support + migrations #628

feat: add postgres support + migrations #628

dr-carrot commented Jan 19, 2024 •

edited

Loading

Fallenbagel commented Jan 20, 2024

dr-carrot commented Jan 20, 2024

captmicr0 commented Jun 7, 2024

github-actions bot commented Jun 13, 2024

Lebowski89 commented Jun 20, 2024 •

edited

Loading

croneter commented Jun 21, 2024

Fallenbagel May 10, 2024

Fallenbagel May 10, 2024

Fallenbagel commented Jun 21, 2024

github-actions bot commented Jun 23, 2024

nodadyoushutup commented Jul 6, 2024

joaopedrocg27 commented Jul 20, 2024

RyuunosukeDS3 commented Aug 6, 2024

juanlurie commented Aug 12, 2024

feat: add postgres support + migrations #628

Are you sure you want to change the base?

feat: add postgres support + migrations #628

Conversation

dr-carrot commented Jan 19, 2024 • edited Loading

Description

Screenshot (if UI-related)

To-Dos

Issues Fixed or Closed

TODO:

Fallenbagel commented Jan 20, 2024

dr-carrot commented Jan 20, 2024

captmicr0 commented Jun 7, 2024

github-actions bot commented Jun 13, 2024

Lebowski89 commented Jun 20, 2024 • edited Loading

croneter commented Jun 21, 2024

Fallenbagel May 10, 2024

Choose a reason for hiding this comment

Fallenbagel May 10, 2024

Choose a reason for hiding this comment

Fallenbagel commented Jun 21, 2024

github-actions bot commented Jun 23, 2024

nodadyoushutup commented Jul 6, 2024

joaopedrocg27 commented Jul 20, 2024

RyuunosukeDS3 commented Aug 6, 2024

juanlurie commented Aug 12, 2024

dr-carrot commented Jan 19, 2024 •

edited

Loading

Lebowski89 commented Jun 20, 2024 •

edited

Loading