update cache times

FancyMcPlugins · Sep 3, 2024 · c490aa1 · c490aa1
1 parent 3487530
commit c490aa1
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/api/src/main/java/de/oliver/fancynpcs/api/utils/SkinFetcher.java b/api/src/main/java/de/oliver/fancynpcs/api/utils/SkinFetcher.java
@@ -139,7 +139,7 @@ public static CompletableFuture<SkinData> fetchSkinByUUID(String uuid) {
 
                 skinCache.put(uuid, skinData);
 
-                FancyNpcsPlugin.get().getSkinCache().upsert(new SkinCacheData(skinData, System.currentTimeMillis(), 1000L * 60 * 60 * 24 * 12)); //TODO: add some randomization
+                FancyNpcsPlugin.get().getSkinCache().upsert(new SkinCacheData(skinData, System.currentTimeMillis(), 1000L * 60 * 60 * 24 + randomFromTo(15, 30))); // 15-30 days
                 FancyNpcsPlugin.get().getPlugin().getLogger().info("Fetched skin data for UUID " + uuid);
                 return skinData;
             } catch (IOException e) {
@@ -176,7 +176,7 @@ public static CompletableFuture<SkinData> fetchSkinByURL(String skinURL) {
                 String signature = obj.getAsJsonObject("data").getAsJsonObject("texture").getAsJsonPrimitive("signature").getAsString();
                 SkinData skinData = new SkinData(skinURL, value, signature);
 
-                FancyNpcsPlugin.get().getSkinCache().upsert(new SkinCacheData(skinData, System.currentTimeMillis(), 1000L * 60 * 60 * 24 * 30 * 12));
+                FancyNpcsPlugin.get().getSkinCache().upsert(new SkinCacheData(skinData, System.currentTimeMillis(), 1000L * 60 * 60 * 24 * randomFromTo(30, 30 * 3))); // 1-3 months
 
                 skinCache.put(skinURL, skinData);
                 FancyNpcsPlugin.get().getPlugin().getLogger().info("Fetched skin data for URL " + skinURL);
@@ -201,6 +201,10 @@ private static boolean isUUID(String identifier) {
         return identifier.length() == 36 && identifier.contains("-");
     }
 
+    private static long randomFromTo(long from, long to) {
+        return from + (long) (Math.random() * (to - from));
+    }
+
     /**
      * Represents all required data for a skin.
      *