Rework how skins are handled

.github/workflows/build.yml

@@ -2,7 +2,9 @@ name: Build plugin
 
 on:
   push:
-
+  pull_request:
+    types:
+      - opened
 jobs:
   build-plugin:
     runs-on: ubuntu-latest

api/src/main/java/de/oliver/fancynpcs/api/FancyNpcsConfig.java

@@ -15,10 +15,14 @@ public interface FancyNpcsConfig {
 
     int getAutoSaveInterval();
 
+    int getNpcUpdateInterval();
+
     int getTurnToPlayerDistance();
 
     int getVisibilityDistance();
 
+    int getRemoveNpcsFromPlayerlistDelay();
+
     List<String> getBlockedCommands();
 
     Map<String, Integer> getMaxNpcsPerPermission();

api/src/main/java/de/oliver/fancynpcs/api/FancyNpcsPlugin.java

@@ -2,6 +2,7 @@
 
 import de.oliver.fancylib.serverSoftware.schedulers.FancyScheduler;
 import de.oliver.fancylib.translations.Translator;
+import de.oliver.fancynpcs.api.utils.SkinCache;
 import org.bukkit.Bukkit;
 import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPlugin;
@@ -36,4 +37,6 @@ static FancyNpcsPlugin get() {
     AttributeManager getAttributeManager();
 
     Translator getTranslator();
+
+    SkinCache getSkinCache();
 }

api/src/main/java/de/oliver/fancynpcs/api/NpcData.java

@@ -17,7 +17,8 @@ public class NpcData {
     private final String name;
     private final UUID creator;
     private String displayName;
-    private SkinFetcher skin;
+    private SkinFetcher.SkinData skin;
+    private boolean mirrorSkin;
     private Location location;
     private boolean showInTab;
     private boolean spawnEntity;
@@ -36,14 +37,13 @@ public class NpcData {
     private float scale;
     private Map<NpcAttribute, String> attributes;
     private boolean isDirty;
-    private boolean mirrorSkin;
 
     public NpcData(
             String id,
             String name,
             UUID creator,
             String displayName,
-            SkinFetcher skin,
+            SkinFetcher.SkinData skin,
             Location location,
             boolean showInTab,
             boolean spawnEntity,
@@ -141,11 +141,11 @@ public NpcData setDisplayName(String displayName) {
         return this;
     }
 
-    public SkinFetcher getSkin() {
+    public SkinFetcher.SkinData getSkin() {
         return skin;
     }
 
-    public NpcData setSkin(SkinFetcher skin) {
+    public NpcData setSkin(SkinFetcher.SkinData skin) {
         this.skin = skin;
         isDirty = true;
         return this;

api/src/main/java/de/oliver/fancynpcs/api/utils/SkinCache.java

@@ -0,0 +1,26 @@
+package de.oliver.fancynpcs.api.utils;
+
+import java.util.List;
+
+public interface SkinCache {
+
+    /**
+     * Load all cached skins from the cache and removes all expired skins
+     *
+     * @return List of cached skins
+     */
+    List<SkinFetcher.SkinCacheData> load();
+
+    /**
+     * Save a skin to the cache
+     *
+     * @param skinCacheData Skin data to save
+     * @param onlyIfExists  If true, the skin will only be replaced/updated if it already exists in the cache
+     */
+    void upsert(SkinFetcher.SkinCacheData skinCacheData, boolean onlyIfExists);
+
+    default void upsert(SkinFetcher.SkinCacheData skinCacheData) {
+        upsert(skinCacheData, false);
+    }
+
+}