Skip to content

Commit

Permalink
Remove Hybrid search (#97)
Browse files Browse the repository at this point in the history
* Remove Hybrid search

* Bump version and upgrade dependencies

* Minify images a bit

* Bump version in manifest

* Fall back to precise search if searchMode could not be detected

---------

Co-authored-by: Simon Heimler <[email protected]>
  • Loading branch information
Fannon and Simon Heimler authored Apr 29, 2023
1 parent 34c1101 commit 314370a
Show file tree
Hide file tree
Showing 22 changed files with 117 additions and 192 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## [unreleased]

## [v1.8.8]

- **FIXED**: Fuzzy search now also works with non-ASCII characters like CKJ chars by default
- **FIXED**: Option `bookmarkColor` now also applies to the bookmark folder badge in the search results
- **REMOVED**: Removed hybrid search as the benefits / differences against new fuzzy search are negligible.

## [v1.8.7]

- **NEW**: New option `uFuzzyOptions` that allows to configure the fuzzy search library used by this extension
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ It supports three different search approaches:

- **Exact search** (case-insensitive, but exact matching): Faster, but only exact matching results.
- **Fuzzy search** (approximate matching): Slower, but includes also inexact (fuzzy) matches.
- **Hybrid search** (combination): Combines results of both approaches.

With this extension you can also **tag your bookmarks** including auto completions.
The tags are considered when searching and can be used for navigation.
Expand Down
47 changes: 0 additions & 47 deletions cypress/e2e/search.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,53 +183,6 @@ describe('Search View', () => {
.checkNoErrors()
})

describe('Hybrid search', () => {
it('can switch to hybrid search successfully', () => {
cy.get('#search-approach-toggle')
.wait(interactionTime)
.contains('PRECISE')
.click()
.wait(interactionTime)
.contains('FUZZY')
.click()
.wait(interactionTime)
.contains('HYBRID')
.get('#search-input')
.type(`JSON`)
.get('li.bookmark')
.checkNoErrors()
})

it('can execute a hybrid search successfully', () => {
cy.get('#search-approach-toggle')
.wait(interactionTime)
.contains('PRECISE')
.click()
.wait(interactionTime)
.contains('FUZZY')
.click()
.wait(interactionTime)
.contains('HYBRID')
.wait(interactionTime)
.get('#search-input')
.type(`JSON`)
.get('li.bookmark')
.get('#result-list')
.should('not.have.length', 0)
.find('[x-original-id=9]')
// Check that we have all kinds of results
.get('#result-list')
.find('li.bookmark')
.get('#result-list')
.find('li.history')
.get('#result-list')
.find('li.tab')
.get('#result-list')
.find('li.bookmark')
.checkNoErrors()
})
})

describe('Bookmark search', () => {
it('Empty search returns recent bookmarks', () => {
cy.get('#search-input')
Expand Down
Binary file modified images/logo-128.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/logo-32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/logo-48.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/logo-64.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/promo-1400.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/promo-300.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/promo-440-alt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/promo-440.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/promo-920.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions images/x.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion manifest.firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
"homepage_url": "https://github.com/Fannon/search-bookmarks-history-and-tabs",
"author": "Simon Heimler",
"version": "1.8.6",
"version": "1.9.0",
"manifest_version": 2,
"applications": {
"gecko": {
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
"homepage_url": "https://github.com/Fannon/search-bookmarks-history-and-tabs",
"author": "Simon Heimler",
"version": "1.8.6",
"version": "1.9.0",
"manifest_version": 3,
"permissions": ["tabs", "bookmarks", "history", "storage"],
"action": {
Expand Down
Loading

0 comments on commit 314370a

Please sign in to comment.