Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tests passing #566

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kbhalerao
Copy link

What is the purpose of your pull request?

  • Bug fix
  • New feature

Proposed changes

Modified the branch to make the following changes:

  1. Reconciled language symbols to match Django 3.0's specification (https://github.com/django/django/blob/master/django/conf/global_settings.py)
  2. Replaced {% load staticfiles %} with {% load static %} (https://docs.djangoproject.com/en/dev/releases/3.0/#features-removed-in-3-0, deprecated in 2.1)
  3. Fixed a couple tests testing for the visbility and existence of an Entry based on a timestamp - the test dates were not appropriate for the tests, and
  4. Fixed a test in tests_views, where only 3 queries were being used instead of 5.

Warning

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the PEP 8.

…uage symbols to match Django 3.0's specification (https://github.com/django/django/blob/master/django/conf/global_settings.py); 2) Replaced {% load staticfiles %} with {% load static %} (https://docs.djangoproject.com/en/dev/releases/3.0/#features-removed-in-3-0, deprecated in 2.1) 3) Fixed a couple tests testing for the visbility and existence of an Entry based on a timestamp - the test dates were not appropriate for the tests, and 4) Fixed a test in tests_views, where only 3 queries were being used instead of 5. All existing tests are passing
@Eyap53
Copy link

Eyap53 commented Sep 25, 2020

Hi, i believe you also should rename the locale folders (in zinnia/locale/) to reflect your changes of language symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants