Fix LinuxEvents destructor to close all fd #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Can you explain this code? |
|
Certainly. It takes the last opened file descriptor (fd) assigned in the for-loop lines 41-51. Then it closes this fd and the next x-1 smaller fd, where x is the number of perf events (stored in num_events) for the LinuxEvents instance. Obviously this is a hack, as the really opened fd are not used, but guessed. |
thomasmueller
requested changes
Nov 30, 2020
Most probably a cleaner and more general solution. I should add that I am not sure how the start/end method is working with just the last fd. This is why I decided to just do a fix in the destructor and leave everything else as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here would be how I solved running out of fds.