Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip the FIELD_NAME following the last creator property during @JsonUnwrapped property-based deserialization #2089

Closed
wants to merge 1 commit into from

Conversation

6bangs
Copy link

@6bangs 6bangs commented Jul 16, 2018

(fix for #2088)

Certainly expecting that I missed something here 😄

@6bangs 6bangs changed the title Fix #2088 Don't skip the FIELD_NAME following the last creator property during @JsonUnwrapped property-based deserialization Jul 16, 2018
@cowtowncoder
Copy link
Member

Excellent! Thank you very much for reporting the problem, troubleshooting AND contributing the fix.
I think you are on right track here, but I'll need to manually merge this in 2.9. And will read the fix with thought; token position is bit... sensitive thing so need to proceed carefully wrt loop.

@6bangs
Copy link
Author

6bangs commented Aug 29, 2018

Happy to help, thanks!

@6bangs 6bangs closed this Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants