Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use static PropertyNamingStrategy instances in POJOPropertiesCollector._findNamingStrategy() #4109

Closed
wants to merge 2 commits into from
Closed

Use static PropertyNamingStrategy instances in POJOPropertiesCollector._findNamingStrategy() #4109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac95b2f
Use static PropertyNamingStrategy instances in POJOPropertiesCollecto…
takezoe Sep 8, 2023
0c4e911
Move switching logic to PropertyNamingStrategies
takezoe Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,50 @@ private PropertyNamingStrategy _findNamingStrategy()
return pns;
}
}

Copy link
Member

@JooHyukKim JooHyukKim Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

// Plz check Line 1448
PropertyNamingStrategy pns = hi.namingStrategyInstance(_config, _classDef, namingClass);

Possibly, at line 1448 (above) HandlerInstantiator is also doing what we are trying to prevent to happen here. namingStrategyInstance() JavaDoc says....

/**
  * Method called to construct a NamingStrategy instance used for specified
  * class.
  *
  * @since 2.1
  */

Copy link
Contributor Author

@takezoe takezoe Oct 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HandlerInstantiator is given through configuration and it can return any instance of PropertyNamingStrategy. I think we can't rescue if HandlerInstantiator is used.

// PropertyNamingStrategy
if (namingClass == PropertyNamingStrategy.SnakeCaseStrategy.class) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this list of if stmts be made into a switch stmt with cases instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know the baseline version Java 8 doesn't support switch for Class 🧐

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to do this, I think switch logic should be moved into a static method of PropertyNamingStrategies, so here we would just call that method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved switching logic to PropertyNamingStrategies and added a test case.

return PropertyNamingStrategies.SNAKE_CASE;
}
if (namingClass == PropertyNamingStrategy.UpperCamelCaseStrategy.class) {
return PropertyNamingStrategies.UPPER_CAMEL_CASE;
}
if (namingClass == PropertyNamingStrategy.KebabCaseStrategy.class) {
return PropertyNamingStrategies.KEBAB_CASE;
}
if (namingClass == PropertyNamingStrategy.LowerDotCaseStrategy.class) {
return PropertyNamingStrategies.LOWER_DOT_CASE;
}
if (namingClass == PropertyNamingStrategy.LowerCaseWithUnderscoresStrategy.class) {
return PropertyNamingStrategies.SNAKE_CASE;
}
if (namingClass == PropertyNamingStrategy.PascalCaseStrategy.class) {
return PropertyNamingStrategies.UPPER_CAMEL_CASE;
}

// PropertyNamingStrategies
if (namingClass == PropertyNamingStrategies.SnakeCaseStrategy.class) {
return PropertyNamingStrategies.SNAKE_CASE;
}
if (namingClass == PropertyNamingStrategies.UpperSnakeCaseStrategy.class) {
return PropertyNamingStrategies.UPPER_SNAKE_CASE;
}
if (namingClass == PropertyNamingStrategies.LowerCamelCaseStrategy.class) {
return PropertyNamingStrategies.LOWER_CAMEL_CASE;
}
if (namingClass == PropertyNamingStrategies.UpperCamelCaseStrategy.class) {
return PropertyNamingStrategies.UPPER_CAMEL_CASE;
}
if (namingClass == PropertyNamingStrategies.LowerCaseStrategy.class) {
return PropertyNamingStrategies.LOWER_CASE;
}
if (namingClass == PropertyNamingStrategies.KebabCaseStrategy.class) {
return PropertyNamingStrategies.KEBAB_CASE;
}
if (namingClass == PropertyNamingStrategies.LowerDotCaseStrategy.class) {
return PropertyNamingStrategies.LOWER_DOT_CASE;
}

return (PropertyNamingStrategy) ClassUtil.createInstance(namingClass,
_config.canOverrideAccessModifiers());
}
Expand Down