Fixes for #420: Wrap unexpected IOOBE #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
fix-IOOBE
branch
from
10fdbde
to
6903623
Compare
| @@ -549,6 +549,8 @@ public JsonToken nextToken() throws IOException | |||
| type = _reader.next(); | |||
| } catch (IonException e) { | |||
| _wrapError(e.getMessage(), e); | |||
| } catch (IndexOutOfBoundsException e) { | |||
| _constructError(e.getMessage(), e); | |||
There was a problem hiding this comment.
Needs to be thrown, will add throw in front.
cowtowncoder
approved these changes
Dec 16, 2023
cowtowncoder
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a possible fix for #420 by wrapping the unexpected IOOBE when handling invalid or malformed data.