Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close IOContexts #427

Merged
merged 2 commits into from
Aug 31, 2023
Merged

close IOContexts #427

merged 2 commits into from
Aug 31, 2023

Conversation

pjfanning
Copy link
Member

needed after FasterXML/jackson-core#1064

If I have time, I can come back and try to add tests that check that buffer recyclers are being recycled.

@pjfanning pjfanning mentioned this pull request Aug 31, 2023
Merged
cowtowncoder
cowtowncoder reviewed Aug 31, 2023
View reviewed changes
toml/src/main/java/com/fasterxml/jackson/dataformat/toml/TomlGenerator.java
}
_ioContext.close();
// Internal buffer(s) generator has can now be released as well
_releaseBuffers();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved before IOContext.close() (not a huge deal, but it will likely return buffers into recycler, and that should happen before releasing recycler into pool).
I can move after merge.

@cowtowncoder
Copy link
Member

Ok, so this does not depend on change in jackson-core, yet; but when that is merged, we'd probably want to sort of undo some of these changes, right?

I'll go ahead and merge this for time being, regardless.

@cowtowncoder cowtowncoder merged commit bbfdf92 into FasterXML:2.16 Aug 31, 2023
3 checks passed
cowtowncoder added a commit that referenced this pull request Aug 31, 2023
@cowtowncoder
Minor tweak to #427
d8495b3
@pjfanning pjfanning deleted the close-iocontexts branch August 31, 2023 21:01
@pjfanning
Copy link
Member Author

Ok, so this does not depend on change in jackson-core, yet; but when that is merged, we'd probably want to sort of undo some of these changes, right?

I'll go ahead and merge this for time being, regardless.

if FasterXML/jackson-core#1064 is merged, there will need to be some changes in jackson-dataformats-text

@cowtowncoder
Copy link
Member

Yes, I merged #1064.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @cowtowncoder