Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no-arg constructor for DateTimeDeserializer #125

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

abbychau
Copy link

issue #124

@cowtowncoder
Copy link
Member

Quick question here... I am bit confused: constructor being added takes 1 argument; it's not a no-args constructor. I should have noticed and mentioned this earlier. This would not work with annotations yet, only truly 0-argument constructor would.

@abbychau
Copy link
Author

sorry. You are right. I made a mistake. I just changed that to a 0-arg.

@cowtowncoder
Copy link
Member

Ok; this might work, but I think one thing we really need here is a unit test, to verify specified usage works.
Especially since is a new feature at this point, something that did not work before.

Would it be possible to add that? Apologies for not asking for this earlier.

@abbychau
Copy link
Author

@cowtowncoder just added. Could you check whether the test case matches the standard?

@cowtowncoder
Copy link
Member

Looks good. Thank you! Will merge for 2.14.

@cowtowncoder cowtowncoder merged commit 87383d3 into FasterXML:2.14 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants