fix master branch build error around Deprecation Error #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@k163377 WDYT? I'd like you to verify this is the way to go as I don't know enough. CI passes so that makes sense. |
| @@ -18,10 +18,8 @@ fun Class<*>.isKotlinClass(): Boolean = this.isAnnotationPresent(Metadata::class | |||
| * map object. | |||
| * @property nullIsSameAsDefault Default false. Whether to treat null values as absent when deserializing, thereby | |||
| * using the default value provided in Kotlin. | |||
| * @property singletonSupport Default: DISABLED. Mode for singleton handling. | |||
| * @property enabledSingletonSupport Default: DISABLED. Mode for singleton handling. | |||
There was a problem hiding this comment.
I think default is either true or false, not enum, since we have:
val enabledSingletonSupport: Boolean = KotlinFeature.SingletonSupport.enabledByDefault,
|
It may be some error related to @JooHyukKim |
|
@cowtowncoder @k163377 Applied suggestions/fixes. Thanks! |
|
@cowtowncoder Good as far as I know but I think @k163377 has the final say here :) |
k163377
approved these changes
Jun 29, 2024
|
Thank you for the correction and sorry for the delay in checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #813